Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect namespace links in masthead to namespace list with filter #334

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

richard-cox
Copy link
Member

Summary

Fixes #324

Occurred changes and/or fixed issues

  • For resources that are namespaced, the masthead shows a link to the namespace
  • In dashboard world that would be the detail page of a namespace resource
  • In epinio world we have no namespace detail page, so take user to namespace list with query filter to show it
  • This could result in false positives but is better than a dead end
    • namespaces a, aa and aaa would all show up if user went to view namespace with name a

- For resources that are namespaced, the masthead shows a link to the namespace
- In dashboard world that would be the detail page of a namespace resource
- In epinio world we have no namespace detail page, so take user to namespace list with query filter to show it
- This could result in false positives but is better than a dead end
  - namespaces `a`, `aa` and `aaa` would all show up if user went to view namespace with name `a`
@richard-cox richard-cox added the kind/bug Something isn't working label Sep 4, 2023
@richard-cox richard-cox added this to the v1.10.0 milestone Sep 4, 2023
@richard-cox richard-cox self-assigned this Sep 4, 2023
Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Applications and Services list pages. LGTM

@richard-cox richard-cox merged commit 39aee3b into epinio:main Sep 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Blank screen after clicking on namespace link on Instances page
2 participants